Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR suggestion: Remove graph_data_model parameter in create_manifests to simplify the code #1499

Open
wants to merge 5 commits into
base: FDS-1797-input-graph-api
Choose a base branch
from
Open

PR suggestion: Remove graph_data_model parameter in create_manifests to simplify the code #1499

wants to merge 5 commits into from

Conversation

linglp
Copy link
Contributor

@linglp linglp commented Sep 11, 2024 •
edited
Loading

Problem:

  • the graph_data_model parameter was added to create_manifests function. But this parameter is not necessary

Changes:

  • Remove graph_data_model parameter in create_manifests function
  • Have create_manifests function to handle reading pickle files

@linglp linglp changed the base branch from develop to FDS-1797-input-graph-api September 11, 2024 17:20
@linglp linglp mentioned this pull request Sep 11, 2024
Open
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 11, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afwillia afwillia Awaiting requested review from afwillia

@andrewelamb andrewelamb Awaiting requested review from andrewelamb andrewelamb is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@linglp